Merged
Conversation
lewisgoddard
previously approved these changes
Feb 27, 2026
Member
|
I didn't want things to break when new images are added, so the image build steps are back in but they don't overwrite existing ones. This only adds a second or two compared to not checking. I also added a new command |
lewisgoddard
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2396
Have a static images folder
Instead of rebuilding images all the time, commit the optimized images to the images folder and make it trackable by git.
This is just the output of the images task run and committed, which I believe should be all we need to do because we do not fingerprint the images themselves.
This pull request is ready for review.